[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/15] char-pty: Drop "char device redirected to
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH 03/15] char-pty: Drop "char device redirected to" message |
|
Date: |
Tue, 9 Apr 2019 12:40:03 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/8/19 2:31 PM, Markus Armbruster wrote:
> Marc-André Lureau <address@hidden> writes:
>
>> Hi
>>
>> On Mon, Apr 8, 2019 at 10:36 AM Markus Armbruster <address@hidden> wrote:
>>>
>>> char_pty_open() prints a "char device redirected to PTY_NAME (label
>>> LABEL)" message to the current monitor or else to stderr. No other
>>> ChardevClass::open() prints anything on success. Drop the message.
>>>
>>> Cc: "Marc-André Lureau" <address@hidden>
>>> Cc: Paolo Bonzini <address@hidden>
>>> Signed-off-by: Markus Armbruster <address@hidden>
>>> ---
>>> chardev/char-pty.c | 2 --
>>> 1 file changed, 2 deletions(-)
>>>
>>
>> I guess that was printed for convenience.
>>
>> Allocated pty can be read from "info chardev", so I suppose we can
>> make qemu more silent. Fine with me:
>>
>> Reviewed-by: Marc-André Lureau <address@hidden>
>
> Thanks!
>
> If we should decide the message is still useful enough to be worth
> keeping, I could direct it to stdout instead of dropping it.
I prefer this, if Marc-André is still OK.
[Qemu-devel] [PATCH 05/15] mips/boston: Report errors with error_report(), not error_printf(), Markus Armbruster, 2019/04/08
[Qemu-devel] [PATCH 01/15] qemu-img: Use error_vreport() in error_exit(), Markus Armbruster, 2019/04/08
[Qemu-devel] [PATCH 10/15] vl: Make -machine $TYPE, help and -accel help print to stdout, Markus Armbruster, 2019/04/08
[Qemu-devel] [PATCH 04/15] loader-fit: Wean off error_printf(), Markus Armbruster, 2019/04/08