Re: Hello + Intro + Patch

[Jon Phillips]

On Tue, 2004-09-14 at 23:21, Jean-Yves Lefort wrote:
> On Tue, 14 Sep 2004 22:59:37 +0900
> Jon Phillips <address@hidden> wrote:
> 
> > Something though that has bothered me is the lack of a save session menu
> > item.
> > 
> > I added this as Save Session with Control + S.
> 
> There's no point in having such a menu item: the session can be saved
> automatically by enabling "Save session upon exit" in the
> preferences. If it is disabled, the user is prompted on exit.
> 

I disagree, as this is only saved if there is a clean exit and not a
nasty one, as I had happen a couple of times. Why not have something
that users are use to in order to feel confident their settings are
saved. I lost my settings like 20 times just becuase the app crashed or
my system was restarted or whatnot.

I think it is valuable to apply to the main version.

> Moreover, the current scheme where the whole session (which can be
> quite fat) is loaded on startup and saved on exit is not very nice
> performance-wise. Actually, a rewrite of streamtuner is in progress
> (though very idle at the moment): the CVS version is a GStreamer-based
> audio player similar to Rhythmbox, where directories are stored as
> separate XML files and loaded/saved only when needed.
> 

Agree...sounds good...

> Btw, please do not use C++-style comments.
> 

Ok...I didn't see a coding styles document in the tree. But I figured
that some comments are better than the complete lack as is in the
current version.

> > If I received CVS acces I could do more stuff probably, but I can't find
> > mention of this on the site.
> 
> The CVS repository is currently kept on my own workstation; Savannah
> has too much problems for me to rely on their CVS repo.

sourceforge.net has been stable for some months now...

Overall...I was just trying to help and I hope that my efforts aren't
totally wasted...

Thanks for considering my patch,
Jon


-- 
Jon Phillips

KOREA.PH.010.3140.7483
USA.PH.858.361.2811
address@hidden
http://www.rejon.org

Inkscape (http://inkscape.org)
Open Clip Art Library (www.openclipart.org)
CVS Book (http://cvsbook.ucsd.edu/)
Scale Journal (http://scale.ucsd.edu/)