Re: Hello + Intro + Patch

[Jean-Yves Lefort]

On Tue, 14 Sep 2004 23:36:01 +0900
Jon Phillips <address@hidden> wrote:

> On Tue, 2004-09-14 at 23:21, Jean-Yves Lefort wrote:
> > On Tue, 14 Sep 2004 22:59:37 +0900
> > Jon Phillips <address@hidden> wrote:
> > 
> > > Something though that has bothered me is the lack of a save session menu
> > > item.
> > > 
> > > I added this as Save Session with Control + S.
> > 
> > There's no point in having such a menu item: the session can be saved
> > automatically by enabling "Save session upon exit" in the
> > preferences. If it is disabled, the user is prompted on exit.
> > 
> 
> I disagree, as this is only saved if there is a clean exit and not a
> nasty one, as I had happen a couple of times. Why not have something
> that users are use to in order to feel confident their settings are
> saved. I lost my settings like 20 times just becuase the app crashed or
> my system was restarted or whatnot.

streamtuner should not, and afaik does not crash. If it crashes please
provide a backtrace.

> > Btw, please do not use C++-style comments.
> > 
> 
> Ok...I didn't see a coding styles document in the tree. But I figured
> that some comments are better than the complete lack as is in the
> current version.

Readable code needs very little commenting. Regarding the coding
style, obviously you should use C comments for C code and C++ comments
for C++ code.

> Overall...I was just trying to help and I hope that my efforts aren't
> totally wasted...

Thanks.

-- 
Jean-Yves Lefort

address@hidden
http://lefort.be.eu.org/

pgp_ZdLsjMqcC.pgp
Description: PGP signature