Re: Reproducible work with natively compiled Emacs

[Pedro Andres Aranda Gutierrez]

Hi Ihor,

attached is the patch in what I would call the final version. The main enhancement is that

make native and make cleaneln with exit gracefully on systems where native compilation is not enabled.

Best, /PA 

On Thu, 14 Mar 2024 at 07:49, Pedro Andres Aranda Gutierrez <paaguti@gmail.com> wrote:

HI,

On Wed, 13 Mar 2024 at 18:13, Ihor Radchenko <yantar92@posteo.net> wrote:

Pedro Andres Aranda Gutierrez <paaguti@gmail.com> writes:

> Thanks for the feedback! I'm attaching a unified patch.

Thanks!
Some more comments.

> +# This is where Emacs stores the .eln files
> +ELNDIR        = $(shell $(EMACS) --batch --eval '(princ (car native-comp-eln-load-path))')

Maybe := is better here. Otherwise, we risk invoking emacs multiple times.

You are right

> +cleaneln::

Why ::?

You are absolutely right, it's an isolated rule and it doesn't need ::  

--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Patch will follow. I'm testing it against an Emacs WITHOUT native-comp to check it there too.

Best, /PA
--

Fragen sind nicht da, um beantwortet zu werden,

Fragen sind da um gestellt zu werden

Georg Kreisler

Headaches with a Juju log:

unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run a leader-deposed hook here, but we can't yet

--

Fragen sind nicht da, um beantwortet zu werden,

Fragen sind da um gestellt zu werden

Georg Kreisler

Headaches with a Juju log:

unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run a leader-deposed hook here, but we can't yet

0001-Make-cleaneln-work-execute-cleanly-when-native-comp-.patch
Description: Text Data