Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink

[Leo Butler]

On Sun, Mar 17 2024, Ihor Radchenko <yantar92@posteo.net> wrote:

> Leo Butler <Leo.Butler@umanitoba.ca> writes:
>
>>>> I'd prefer to keep this information in the INFO channel.
>>>> It will be more consistent.
>>
>> Apologies, I messed up the patch in the previous email.
>>
>> Attached is a patch that compiles cleanly and uses INFO.
>
> Thanks!
>
>> +         (frame (let ((selection
>> +                       (or (and fragilep
>> +                                (or (string-search "\\begin{frame}" 
>> contents)
>> +                                    (string-search "\\end{frame}" contents))
>
> Please use `string-match-p'. `string-search' is not available in Emacs
> 27, which we still support.

Done.

>
>> +                                org-beamer-frame-environment)
>> +                           "frame")))
>> +                  (unless (string= selection "frame")
>> +                    (setq info (plist-put info :define-frame t)))
>
> Let's use "beamer" prefix to indicate that this plist entry is
> beamer backend-specific. Something like :beamer-define-frame.

Done.

Attached is the updated patch. In addition, I have written three
regression tests that are attached in a separate patch.

Leo

0001-lisp-ox-beamer.el-constrain-use-of-org-beamer-frame-.patch
Description: 0001-lisp-ox-beamer.el-constrain-use-of-org-beamer-frame-.patch

0002-testing-lisp-test-ox-beamer.el-New-regression-tests-.patch
Description: 0002-testing-lisp-test-ox-beamer.el-New-regression-tests-.patch