Re: [Gnash-dev] OpenVG support coming

[Rob Savoye]

On 03/22/11 11:51, Benjamin Wolsey wrote:

> I can't currently compile this code because I don't have openvg on my
> machines.

  Currently OpenVG is available on Ubuntu Maverick or Natty. I'll be
working on the GTK-OpenVG glue this week, which you would need to
actually test it on your desktop. It currently only works with the
nouveau driver and libMesa. Or you could buy an ARM based machine like
the Freescale Babbage, or a Genesi SmartTop, which is where I've done
most of the development.

> bases into a large mess (not to be confused with 'complex'). If the old
> functions are to be replaced, code in the existing three renderers needs
> to be adapted to the new accessor and the old accessors removed.

  I didn't adapt the existing renders to limit the initial changes to
make it easier to review. Modifying those is on the TODO list after the
merge is complete. I could potentially do that before merging, but would
prefer to do it afterwards.

> I'm not going to review the code extensively because, as Sandro said,
> it's currently not easy to see where the additions are. Before any

  Like I mentioned, libdevice and gui/fb are the main changes other than
the OpenVG renderer itself. I could care less whether you review this
code in detail or not, that's up to you. All I'm doing is giving you and
others the option to review it while I'm still making minor changes. My
hope is this will make the commit have less threats to revert all this
work, which is counter-productive.

> further reading of this code, it would also be nice if the Real
> Programmer would fix at least the errors that his compiler is telling
> him about.

  That's for the merge process, and it'd be more useful if you'd stick
to technical issues. As mentioned in the past, my own personal style is
to do things in phases. With review comments coming in now, those are
the types of changes I'll make before the merge gets committed.

  I agree with strk on this, real hackers are lazy. :-)

        - rob -