[Octave-bug-tracker] [bug #43063] Suitesparse 4.3.x has changed APIs, no longer builds with Octave

[Orion Poplawski]

Follow-up Comment #15, bug #43063 (project octave):

NB that I am not at all familiar with suitesparse, but I think the problem
lies with these parts of the patch:

-  cm->complex_divide = CHOLMOD_NAME(divcomplex);
-  cm->hypotenuse = CHOLMOD_NAME(hypot);
+  suitesparse_assign_function(divcomplex_func, cm->complex_divide,
CHOLMOD_NAME(divcomplex));
+  suitesparse_assign_function(hypot_func, cm->hypotenuse,
CHOLMOD_NAME(hypot));

suitesparse_assign_function(divcomplex_func, cm->complex_divide, 
CHOLMOD_NAME(divcomplex)) assigns the function pointer:

// Cope with new suitesparse versions
//
#if defined( SUITESPARSE_VERSION ) && SUITESPARSE_VERSION >=
SUITESPARSE_VER_CODE(4,3)
#define suitesparse_assign_function(f_name,f_var,f_assign)
(SuiteSparse_config.f_name = f_assign)
#else
#define suitesparse_assign_function(f_name,f_var,f_assign) (f_var = f_assign)
#endif

So SuiteSparse_config.divcomplex_func gets assigned to cholmod_divcomplex. 
But cholmod_divcomplex does:

    return (SuiteSparse_config.divcomplex_func (ar, ai, br, bi, cr, ci)) ;

So it keeps calling itself.  Not sure if the patch or suitesparse is wrong at
this point.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?43063>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/