Re: [bongo-devel] VLC problems on w32

[Dieter Deyke]

Daniel Brockman <address@hidden> writes:

> Dieter Deyke <address@hidden> writes:
>
>> Well, after all these changes things have changed a little:
>>
>> -  the DOS windows is now gone thanks to the new argument to vlc
>
> OK.
>
>> -  the space bar now does nothing, no error, no action
>>
>> -  the || pause button is still missing from the mode line
>>
>> - vlc still hangs after a song is played, and does not advance to the next
>
> What if you try this patch?
>
> --- old-bongo/bongo.el  2007-02-05 06:12:41.000000000 +0100
> +++ new-bongo/bongo.el  2007-02-05 06:12:41.000000000 +0100
> @@ -4650,14 +4650,14 @@
>    (when (not (bongo-player-interactive-p player))
>      (error (concat "This VLC process is not interactive "
>                     "and so does not support pausing")))
> -  (process-send-string (bongo-player-process player) "pause\n"))
> +  (process-send-string (bongo-player-process player) "pause\r\n"))
>
>  (defun bongo-vlc-player-seek-to (player seconds)
>    (when (not (bongo-player-interactive-p player))
>      (error (concat "This VLC process is not interactive "
>                     "and so does not support seeking")))
>    (process-send-string (bongo-player-process player)
> -                       (format "seek %f\n" (max seconds 0)))
> +                       (format "seek %f\r\n" (max seconds 0)))
>    (bongo-player-sought player seconds))
>
>  (bongo-define-obsolete-function-alias
> @@ -4676,10 +4676,10 @@
>          ((and (not (bongo-player-paused-p player))
>                (null (nthcdr 4 (bongo-player-get player 'pending-queries))))
>           (let ((process (bongo-player-process player)))
> -           (process-send-string process "get_time\n")
> +           (process-send-string process "get_time\r\n")
>             (bongo-player-push player 'pending-queries 'time)
>             (when (null (bongo-player-total-time player))
> -             (process-send-string process "get_length\n")
> +             (process-send-string process "get_length\r\n")
>               (bongo-player-push player 'pending-queries 'length))))))
>
>  (defun bongo-vlc-player-start-timer (player)
> @@ -4705,8 +4705,7 @@
>                                       "play state:"
>                                       (zero-or-more space)
>                                       (submatch (one-or-more digit))
> -                                     (zero-or-more (or space ")"))
> -                                     line-end))))
> +                                     (zero-or-more (or space ")"))))))
>                (case (string-to-number (match-string 1))
>                  (1 (bongo-player-put player 'paused nil)
>                     (bongo-player-paused/resumed player)
> @@ -4719,14 +4718,12 @@
>                                       (optional
>                                        (and "[" (zero-or-more digit) "]"))
>                                       (zero-or-more space)
> -                                     "main playlist: nothing to play"
> -                                     line-end))))
> -              (process-send-string process "quit\n"))
> +                                     "main playlist: nothing to play"))))
> +              (process-send-string process "quit\r\n"))
>               ((looking-at (eval-when-compile
>                              (rx (and line-start
>                                       (submatch (one-or-more digit))
> -                                     (zero-or-more space)
> -                                     line-end))))
> +                                     (zero-or-more space)))))
>                (when (bongo-player-get player 'pending-queries)
>                  (let ((value (string-to-number (match-string 1))))
>                    (ecase (bongo-player-shift player 'pending-queries)
>
> --
> Daniel Brockman <address@hidden>

I am sorry to report that that patch did not change the behavior.  I
would have been surprised if it did, because mplayer did not seem to
need \r\n t work.  May be that vlc on windows does not report back on
stdout, but somewhere else, like in that now hidden Console window?  I
am just guessing here.

Thanks,
-- 
Dieter Deyke

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing on usenet and in e-mail?