[bongo-devel] Re: Marks

[Daniel Jensen]

Daniel Brockman <address@hidden> writes:

> address@hidden (Daniel Jensen) writes:
>
>> I don't think it is a good idea to mix unmarking with a stack growing
>> behind the scenes, that's messy. Better to let the user manage this
>> stack separately. How about `* k', `* y' and `* w', kind of like in
>> Gnus? That is, if we want the stack after all.
>
> But what about things like `e'?  If that doesn't push the
> set to the stack before unmarking, I think the usefulness of
> the mark stack is reduced significantly.

How is usefulness of the stack reduced? This is an honest question,
because I don't understand the meaning of what you're saying. If
anything, the usefulness of the stack would increase in this case?

I suppose this could be a customizable feature, to use the stack for
automatically saving marks, but I really don't like it. I'd rather
have a separate variable for automatically saved marks in that case.

> The `* *' command toggles between a set of marks and the
> empty set of marks.

If I understand you correctly; this is like without the stack, only
with a handy key? Sure, I think that complements the original
suggestion (`U' and `C-u U') well.

>> Invert it is, then. If we go with the stack commands, it is also
>> consistent with that in the Gnus-wannabe way.
>
> I don't know why, but I kind of like monkeying after Gnus.
> Everyone knows Gnus is cool.  You know.  Right?

Hey, it makes sense to follow the cool kids. And Bongo is pretty cool
already, don't you think?

> Note:  This still has not been implemented.  We should probably
>        implement it or file a feature request in the tracker.

Does it have to be anything fancier than this?

(defun bongo-invert-marks ()
  "Mark unmarked tracks, and unmark marked tracks in the buffer."
  (interactive)
  (save-excursion
    (goto-char (point-min))
    (while (not (eobp))
      (if (bongo-marked-track-line-p)
          (bongo-unmark-line)
        (when (bongo-track-line-p)
          (bongo-mark-line)))
      (forward-line 1))))