Re: Implementation of music streams

[Erik Sandberg]

On 5/15/06, Han-Wen Nienhuys <address@hidden> wrote:
> Erik Sandberg schreef:
> >> > Here's my plan on how to front-port music streams to the 2.9 branch.
> >> >
> >> > 1. Implement classes Dispatcher, Stream_event, Listener (move modules
> >> > from my thesis fork)
> >> > 2. Add dispatchers event_source_, and possibly events_below_, to
> >> Context
> >> > class.
> >> > 3. Make Context::try_music send stream events to the event_source_.
> >
> > This step is now finished, patch attached. You can notice some
>
> Can you also look my nits regarding warnings and SEND_EVENT_TO_CONTEXT
> below, and commit if "make web" still works?
>
> > additional stuff that has been added as well, which currently is
> > unused but will be used in future patches. You will notice that this
> > patch makes lily spit out lots of Junking Event messages, which are
> > harmless.
>
> Can you make sure that in this patch those warnings are surpressed?
> I don't want to leave lily in a state where it prints bazillions of
> messages.

ok

> Come to think of it, I don't see
> why SEND_EVENT_TO_CONTEXT should be a macro. Is there a reason why it
> can't be a function, except for the ly_symbol2scm() memoization?

no, the memoization is the only reason. I can make the code less
compact (inserting lots of ly_symbol2scm calls) and do it as a
function, if you like.

Erik