lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Revised autobeam settings patch -- cleaned up debug comments (issue1667


From: Carl . D . Sorensen
Subject: Revised autobeam settings patch -- cleaned up debug comments (issue1667044)
Date: Tue, 15 Jun 2010 22:27:48 +0000

Reviewers: ,

Message:
I've posted a revised patch under a new issue, because I was working
with my git branches to get the patch to only include the changed files.

I've eliminated the leftover debug code, fixed up the mistakes in
ly/bagpipe.ly,
and adjusted the description of timeSignatureSettings.

I'm sorry about the confusion on the earlier patch.  I believe this one
is better for review.

Thanks,

Carl


Description:
Revised autobeam settings patch -- cleaned up debug comments
in code and eliminated the irrelevant changes in
Documentation/snippets just due to running makelsr.py


Redo autobeam settings to make resetting easier
Autobeaming now depends on context properties that can be
\set by the user.   When the time signature is changed, default
autobeam settings for the time signature are read and the context
properties are changed to set the autobeaming properties.

This change eliminates \overrideBeamSettings and \revertBeamSettings.

New functions have been defined to set time signature default
properties:
\overrideTimeSignatureSettings
and
\revertTimeSignatureSettings
in order to give autobeam settings persistence through time signature
changes.

A Scheme function make-setting has been defined to make it
easier to create a time signature setting.

Please review this at http://codereview.appspot.com/1667044/show

Affected files:
  M Documentation/de/notation/rhythms.itely
  M Documentation/es/notation/rhythms.itely
  M Documentation/fr/notation/rhythms.itely
  M Documentation/notation/rhythms.itely
  M Documentation/snippets/beam-endings-in-score-context.ly
  M Documentation/snippets/beam-grouping-in-7-8-time.ly
  M Documentation/snippets/compound-time-signatures.ly
  M Documentation/snippets/conducting-signs,-measure-grouping-signs.ly
  M Documentation/snippets/fretted-headword.ly
  M Documentation/snippets/new/beam-endings-in-score-context.ly
  M Documentation/snippets/new/beam-grouping-in-7-8-time.ly
  M Documentation/snippets/new/compound-time-signatures.ly
  M Documentation/snippets/new/conducting-signs,-measure-grouping-signs.ly
  M Documentation/snippets/new/fretted-headword.ly
  M Documentation/snippets/new/reverting-default-beam-endings.ly
  M Documentation/snippets/reverting-default-beam-endings.ly
  M input/regression/les-nereides.ly
  M lily/auto-beam-engraver.cc
  M lily/beam-setting-scheme.cc
  M lily/beaming-pattern.cc
  M lily/include/beam-settings.hh
  M lily/measure-grouping-engraver.cc
  M ly/bagpipe.ly
  M ly/engraver-init.ly
  M ly/music-functions-init.ly
  M python/convertrules.py
  M scm/auto-beam.scm
  M scm/define-context-properties.scm
  M scm/lily-library.scm
  M scm/lily.scm
  M scm/music-functions.scm





reply via email to

[Prev in Thread] Current Thread [Next in Thread]