Re: Revised autobeam settings patch -- cleaned up debug comments (issue1667044)

[Carl Sorensen]

On 6/16/10 3:18 AM, "Trevor Daniels" <address@hidden> wrote:

> 
> 
> Carl.D.Sorensen wrote Tuesday, June 15, 2010 11:27 PM
> 
>> Description:
>> Revised autobeam settings patch -- cleaned up debug comments
>> in code and eliminated the irrelevant changes in
>> Documentation/snippets just due to running makelsr.py
>> 
>> Please review this at http://codereview.appspot.com/1667044/show
> 
> I've run a few examples through this new code and so
> far it all works extremely well.
> 
> One or two of the default beam settings might be
> improved (while you're changing the beaming, that is - I
> think the behaviour below is probably as in the current
> releases, not introduced in this patch).  The most
> important is illustrated by
> 
> \relative c' {
>   \time 3/4
>   % In 3/4 time never beam an odd number of 8th notes or two
>   % 8th notes in different beats
>   f8 f f f f f
>   f16 f f f f f f f f f f f
>   f32 f f f f f f f f f f f
>   f f f f f f f f f f f f
>   f4 r8 f f f     % incorrect!
>   f8 f~f f f f    % incorrect!
>   d'4. c8 b8. a16  % incorrect!
> }
> 
> I think here it would be better to break quaver beams
> every beat (unless you have a trick up your sleeve
> to recognise these incorrect cases).

I found a trick up my sleeve to solve all of them except the tied quavers
(did I use that word right?).  I think I'd prefer to leave the 3/4 quaver
beams at the whole measure, and do a fix on the one case we've found that
doesn't work.

I'll address the other rules separately.

I've put a new patch set on Rietveld:

http://codereview.appspot.com/1667044


Thanks,

Carl