Re: [Patch] make post-event music functions direction-aware (issue3743043)

[Carl . D . Sorensen]

This seems like a cool idea!

Could it be made more simple by just letting the 0 direction be set as a
music property, instead of adding only the 1 and -1 directions?


http://codereview.appspot.com/3743043/diff/1/input/regression/music-function-post-event.ly
File input/regression/music-function-post-event.ly (right):

http://codereview.appspot.com/3743043/diff/1/input/regression/music-function-post-event.ly#newcode1
input/regression/music-function-post-event.ly:1: \version "2.13.43"
Should be 2.13.44, because .43 is already released.  We're working on
.44 now.

http://codereview.appspot.com/3743043/diff/1/scm/ly-syntax-constructors.scm
File scm/ly-syntax-constructors.scm (right):

http://codereview.appspot.com/3743043/diff/1/scm/ly-syntax-constructors.scm#newcode46
scm/ly-syntax-constructors.scm:46: (define-ly-syntax-loc (music-function
parser loc fun args dir)
Why not just let the direction = 0 argument flow through into the music
property?  Does it cause problems to have a direction = 0 in general?

http://codereview.appspot.com/3743043/