lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Patch] make post-event music functions direction-aware (issue374304


From: v . villenave
Subject: Re: [Patch] make post-event music functions direction-aware (issue3743043)
Date: Mon, 20 Dec 2010 23:22:23 +0000

On 2010/12/20 23:18:37, Neil Puttock wrote:
The code looks pretty good, but I agree with Carl that it's too
complicated.
I'd go even further though: you should only be setting direction if
it's
necessary (just like articulations), so there's no need to pass an
extra
argument to the syntax constructor.  Simply set 'direction inside the
parser
rule itself following the function evaluation.

I've been looking for a way of doing this, but it's a bit too advanced
for me (I suspect there must be something to unsmob somewhere or a Music
object or whatever)... Could you give me a hint?

Cheers,
Valentin

http://codereview.appspot.com/3743043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]