Re: [Patch] make post-event music functions direction-aware (issue3743043)

[Carl . D . Sorensen]

On 2010/12/21 20:45:42, Valentin Villenave wrote:
> On 2010/12/20 16:22:30, Carl wrote:


> actually, whilst it does pass make check, it breaks... all of my own
scores!


I can't understand why you don't want to push a patch that breaks all
your scores... ;-)

Does this latest patch break your scores?

> I use the following function:

> filterDirections=
> #(define-music-function (parser location music) (ly:music?)
>    (music-filter
>      (lambda (x)
>        (not (null? (ly:music-property x 'direction))))
>      music))

> that allows me to discriminate dynamics that have an explicit
direction (even a
> neutral one) from those who don't.

What is the logical distinction you want to make between a neutral
direction and the lack of an explicit direction?

I'm a bit nervous about using an undocumented lack of a direction
setting as a signal to do something.  It seems to me to be not very
robust.

Thanks,

Carl


http://codereview.appspot.com/3743043/