Re: Issue 1320: Scheme bar line interface (issue 6305115)

[k-ohara5a5a]

Looks like LilyPond defines two line-thicknesses,
one for staff-line thickness in each StaffSymbol,
and one (confusingly called staffline in C) for bar-line width in
paper.scm.

If the barlines use the layout thickness, as they mostly did in the C
version, then they line up between staves of different staffline
thicknesses.


http://codereview.appspot.com/6305115/diff/46004/scm/bar-line.scm
File scm/bar-line.scm (right):

http://codereview.appspot.com/6305115/diff/46004/scm/bar-line.scm#newcode144
scm/bar-line.scm:144: (stafflinethick (ly:staff-symbol-line-thickness
grob))
this one was not like the others in the C version, but maybe that was a
bug.

http://codereview.appspot.com/6305115/diff/46004/scm/bar-line.scm#newcode155
scm/bar-line.scm:155: (line-thickness (ly:staff-symbol-line-thickness
grob))
unused ?

http://codereview.appspot.com/6305115/diff/46004/scm/bar-line.scm#newcode207
scm/bar-line.scm:207: (line-thickness (ly:staff-symbol-line-thickness
grob))
From layout, or just the value 'thickness' passed in ?

http://codereview.appspot.com/6305115/diff/46004/scm/bar-line.scm#newcode257
scm/bar-line.scm:257: (let* ((line-thickness
(ly:staff-symbol-line-thickness grob))
from layout.

http://codereview.appspot.com/6305115/diff/46004/scm/bar-line.scm#newcode339
scm/bar-line.scm:339: (line-thickness (ly:staff-symbol-line-thickness
grob)))
Confirming, yes, from staff-symbol because it refers to staffline
thickness

http://codereview.appspot.com/6305115/diff/46004/scm/bar-line.scm#newcode372
scm/bar-line.scm:372: (let* ((line-thickness
(ly:staff-symbol-line-thickness grob))
from layout

http://codereview.appspot.com/6305115/diff/46004/scm/bar-line.scm#newcode464
scm/bar-line.scm:464: (let* ((line-thickness
(ly:staff-symbol-line-thickness grob))
the C version used the line-thickness from paper.scm. That is, thickness
of vertical lines comes from layout, not from staff.

http://codereview.appspot.com/6305115/