[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.5 08/30] m68k: update CPU flags management
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH for-2.5 08/30] m68k: update CPU flags management |
Date: |
Thu, 13 Aug 2015 20:09:29 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
Le 12/08/2015 07:12, Richard Henderson a écrit :
> On 08/09/2015 01:13 PM, Laurent Vivier wrote:
>> @@ -798,9 +796,9 @@ void HELPER(mac_set_flags)(CPUM68KState *env,
>
>> @@ -1706,16 +1745,18 @@ DISAS_INSN(branch)
>> /* bsr */
>> gen_push(s, tcg_const_i32(s->pc));
>> }
>> - gen_flush_cc_op(s);
>> if (op > 1) {
>> /* Bcc */
>> l1 = gen_new_label();
>> gen_jmpcc(s, ((insn >> 8) & 0xf) ^ 1, l1);
>> + update_cc_op(s);
>> gen_jmp_tb(s, 1, base + offset);
>> gen_set_label(l1);
>> + update_cc_op(s);
>> gen_jmp_tb(s, 0, s->pc);
>
> Ideally you'd do this only once, before the jmpcc.
This breaks something.
I think we can't do update_cc_op() before gen_jmpcc() because
gen_jmpcc() calls gen_flush_flags().
Laurent
[Qemu-devel] [PATCH for-2.5 17/30] m68k: ori/andi/subi/addi/eori/cmpi can modify SR/CCR, Laurent Vivier, 2015/08/09
[Qemu-devel] [PATCH for-2.5 18/30] m68k: addq/subq can work with all the data sizes., Laurent Vivier, 2015/08/09
[Qemu-devel] [PATCH for-2.5 16/30] m68k: Add all access modes and data sizes to some 680x0 instructions, Laurent Vivier, 2015/08/09
[Qemu-devel] [PATCH for-2.5 20/30] m68k: add exg, Laurent Vivier, 2015/08/09