Re: [lmi] Group quotes, part deux

[Greg Chicares]

On 2016-05-12 22:03, Vadim Zeitlin wrote:
> 
>  I've uploaded the commits implementing the changes discussed in this
> thread to https://github.com/vadz/lmi/pull/28. As usual, I've tested them
> not only with my usual builds (MSVC one under MSW and autotools under
> Linux), but also with the lmi official makefiles under MSW and everything
> seems to work correctly in all cases.

I've applied all patches locally and tested everything extensively, and
it looks like these changes are ready for production.

>  The only questionable decision in these commits I see is my decision to
> treat columns with empty headers as being hidden

I'll consider that when I review and commit each patch. My guess is that
this won't matter because we supply a header for every desired column,
so none will be hidden by accident.

>  Please let me know if you'd like me to do this or would like to propose
> any other changes.

There's one change that I need to make: the spouse rider amount shown in
a footnote is the case total, but the individual amount is wanted instead.

Otherwise, when Kim's back in the office I'd like to discuss these
formatting details, depending on her opinion on their desirability and
yours on the effort required:

- As you've pointed out, centering the amounts in the table means that
numbers of different magnitudes don't line up vertically. Right-justified
columns would be easier to read.

- Totals and averages are formatted differently than tabular data: they
are right justified (which I think is good), but the dollar signs are
separated from the numbers and left justified (which seems unusual to me).

- If any of the six dollar-amount columns are hidden, the space they
would have occupied seems to be reallocated to the "Participant" column.
We might prefer to allocate some of this space to the dollar-amount
columns.