lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] Group quotes, part deux


From: Vadim Zeitlin
Subject: Re: [lmi] Group quotes, part deux
Date: Mon, 16 May 2016 16:53:16 +0200

On Mon, 16 May 2016 12:06:14 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2016-05-13 13:21, Vadim Zeitlin wrote:
GC> > On Fri, 13 May 2016 12:31:26 +0000 Greg Chicares <address@hidden> wrote:
GC> [...]
GC> > GC> - As you've pointed out, centering the amounts in the table means that
GC> > GC> numbers of different magnitudes don't line up vertically. 
Right-justified
GC> > GC> columns would be easier to read.
GC> 
GC> We'll keep it the way it is (centered).
GC> 
GC> > GC> - Totals and averages are formatted differently than tabular data: 
they
GC> > GC> are right justified (which I think is good), but the dollar signs are
GC> > GC> separated from the numbers and left justified (which seems unusual to 
me).
GC> > 
GC> >  Those would be trivial to change and I can quickly implement whichever
GC> > formatting you prefer.
GC> 
GC> We'd like to format totals and averages the same way as the amounts in the
GC> table: dollar sign fused with the numbers, and centered. Would you please
GC> provide a patch to make it so? (github's fine for that purpose.)

 Sure, here is the trivial patch doing this:

        https://github.com/vadz/lmi/pull/29

 I think it might be better to add a helper function for formatting the
amount with the dollar sign now instead of writing

        '$' + ledger_format(...)

in several places but this is rather minor and definitely urgent, please
let me know if you think it would be worth to add such a function any time
soon.

 Thanks,
VZ


reply via email to

[Prev in Thread] Current Thread [Next in Thread]