lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] Group quotes, part deux


From: Greg Chicares
Subject: Re: [lmi] Group quotes, part deux
Date: Mon, 16 May 2016 16:06:42 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0

On 2016-05-16 14:53, Vadim Zeitlin wrote:
> On Mon, 16 May 2016 12:06:14 +0000 Greg Chicares <address@hidden> wrote:
> 
> GC> On 2016-05-13 13:21, Vadim Zeitlin wrote:
[...]
> GC> We'd like to format totals and averages the same way as the amounts in the
> GC> table: dollar sign fused with the numbers, and centered. Would you please
> GC> provide a patch to make it so? (github's fine for that purpose.)
> 
>  Sure, here is the trivial patch doing this:
> 
>       https://github.com/vadz/lmi/pull/29

Committed 20160516T1556Z, revision 6591.

>  I think it might be better to add a helper function for formatting the
> amount with the dollar sign now instead of writing
> 
>       '$' + ledger_format(...)
> 
> in several places but this is rather minor and definitely urgent, please
> let me know if you think it would be worth to add such a function any time
> soon.

Not worth it IMO. This code is already well tested, and who knows whether
someone might ask for a different format someday--e.g.:
  $123.45  <-- dollar sign only on first item in a column
   678.90  <-- no dollar sign on subsequent items




reply via email to

[Prev in Thread] Current Thread [Next in Thread]