Re: [Mldonkey-users] Bug in Overnet source handling causes being banned

[Pierre Etchemaite]

Le Fri, 06 Feb 2004 13:44:20 +0100, address@hidden a écrit :

> I believe that a solution would be to check if a client with the same 
> IP/Port and the same client hash already exists in either edonkey OR 
> overnet sources before adding a new source. (Just checking the IP is not 
> enough, because it is possible that more than one client run on the same 
> machine with a different port & client hash.)

MLdonkey doesn't use the same hash for eDonkey and Overnet, so it won't
work.

client hash on eDonkey is just a peer identifier, with some bytes (6th and
14th or something) used as magic values to enable eMule features.

client hash on Overnet is a peer identifier too, but it's also used to
"locate" the peer in the xor-distance space, and used to determine what keys
will be stored on the local database of that peer.

Since each have their own semantics, it may not be a very good idea to use
the same value for both (eMule magic bytes would restrict peers to some
hyperplane. Not fatal, but not clean either).