Re: [Nano-devel] RFC: line numbers?

[Faissal Bensefia]

On 19/10/16 20:00, Benno Schulenberg wrote:
> 
> On Wed, Oct 19, 2016, at 19:48, Faissal Bensefia wrote:
>> Here you go.
> 
> Hm.  Can I use "Faissal Bensefia <address@hidden>" as the
> sign-off and the author?
> 
I don't see why not, it's what --signoff gives me anyway. Is it the
email? That's the one I use for my GitHub so it's what I use for my Git
config too (it's basically my designated sign up email, the one that I'm
posting from is my personal one).

> 
> I propose to use this as the commit message:
> 
>     new feature: the ability to show line numbers before the text
>     
>     It can be activated with --linenumbers on the command line or with
>     'set linenumbers' in a nanorc file, and it can be toggled with M-#.
> 
> Are you okay with that?
> 
Yeah, I've used that one for this patch (I did change the capitalisation
though).

> One other small thing.  Vim reserves at least three columns
> for line numbers.  Maybe nano should do the same?  So that
> there is no change in appearance when a file grows from 9
> to 10 lines, or from 99 to 100.
> 
> Benno
> 

On 19/10/16 20:40, Chris Allegretta wrote:
> Apologies, not been in the loop until now, but I think it makes sense
> to optimize the layout for at least 99/999 lines by default.

Done, I've made it so that it doesn't change between 9 and 10 lines but
I've left it still changing between 99 to 100 lines (as per Chris'
suggestion) because in my experience I frequently come across <100 line
files (usually either modules or non-source text files).

On 20/10/16 09:41, Benno Schulenberg wrote:
>
> On Wed, Oct 19, 2016, at 21:00, Benno Schulenberg wrote:
>> Hm.  Can I use "Faissal Bensefia <address@hidden>" as the
>> sign-off and the author?
>
> A further tweaked patch is attached: it normalizes an indentation,
> reorders the toggle, and adds --linenumbers to the --help text.
>
> The second patch adds an option to change the color of the
> line numbers.
>
> Benno
>

I've incorporated this in the patch.

Also, Chris, no top posting :^)

~Faissal Bensefia

0001-New-feature-The-ability-to-show-line-numbers-before-.patch
Description: Text Data