Re: Revised autobeam settings patch -- cleaned up debug comments (issue1667044)

[n . puttock]

Hi Carl,

Here are some preliminary comments.  I'll try to give the patch a more
thorough going over at the weekend.

The indentation for the alist in time-signature-settings.scm is a bit
compressed (particularly for beam-settings).  Here's a sample of how it
looks after reindentation:

(define-public default-time-signature-settings
  '(
    ;; in 2 2 time:
    ;;   default: end beams on 1 2 note boundaries
    ;;   end beams with 32nd notes each 1 4 beat
    ((2 . 2) .
     ((beat-length . (1 . 2))
      (measure-grouping . (1 1))
      (beam-settings .
                     ((end .
                           (((1 . 8) . (4 4))
                            ((1 . 32) . (8 8 8 8))))))))

Cheers,
Neil




http://codereview.appspot.com/1667044/diff/21001/22013
File
Documentation/snippets/new/conducting-signs,-measure-grouping-signs.ly
(right):

http://codereview.appspot.com/1667044/diff/21001/22013#newcode1
Documentation/snippets/new/conducting-signs,-measure-grouping-signs.ly:1:
%% Note: this file works from version 2.13.22
remove

http://codereview.appspot.com/1667044/diff/21001/22013#newcode31
Documentation/snippets/new/conducting-signs,-measure-grouping-signs.ly:31:
} % begin verbatim
remove

http://codereview.appspot.com/1667044/diff/21001/22025
File ly/music-functions-init.ly (right):

http://codereview.appspot.com/1667044/diff/21001/22025#newcode425
ly/music-functions-init.ly:425: #(override-time-signature-setting
Is override-time-signature-setting likely to be used outside this music
function wrapper?  If not, then it would be simpler to remove ly:export
from the function and remove the #{ }# block.

(same for revert-time-signature-setting)

http://codereview.appspot.com/1667044/diff/21001/22026
File python/convertrules.py (right):

http://codereview.appspot.com/1667044/diff/21001/22026#newcode3013
python/convertrules.py:3013: stderr_write(NOT_SMART %
_("\overrideBeamSettings is obsolete; see \set BeamSettings and
\overrideTimeSignatureSettings.\n"))
NOT_SMART needs a sentence continuation

http://codereview.appspot.com/1667044/diff/21001/22028
File scm/define-context-properties.scm (right):

http://codereview.appspot.com/1667044/diff/21001/22028#newcode476
scm/define-context-properties.scm:476: time signatures.  Contains an
elements for various time signatures.  The
Contains elements

http://codereview.appspot.com/1667044/diff/21001/22028#newcode477
scm/define-context-properties.scm:477: element for each time signature
contains entries for @code{measure-length},
measureLength

http://codereview.appspot.com/1667044/diff/21001/22028#newcode478
scm/define-context-properties.scm:478: @code{measure-grouping}, and
@code{beamSettings}.")
measureGrouping

http://codereview.appspot.com/1667044/diff/21001/22031
File scm/music-functions.scm (right):

http://codereview.appspot.com/1667044/diff/21001/22031#newcode561
scm/music-functions.scm:561: (map (lambda(x) (/ (* 8 x) den))
lambda (x)

http://codereview.appspot.com/1667044/diff/21001/22032
File scm/time-signature-settings.scm (right):

http://codereview.appspot.com/1667044/diff/21001/22032#newcode197
scm/time-signature-settings.scm:197: ((beat-length . (1 . 4))
I think (3 . 4) is more likely

e.g., Chopin's G minor Ballade

http://codereview.appspot.com/1667044/diff/21001/22033
File scripts/build/output-distance.py (right):

http://codereview.appspot.com/1667044/diff/21001/22033#newcode90
scripts/build/output-distance.py:90: system ('compare -depth 8
%(dir)s/crop1.png %(dir)s/crop2.png %(dir)s/diff.png' % locals ())
not part of this patch set

http://codereview.appspot.com/1667044/show